Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage has dropped while Coveralls has been disabled #1597

Closed
1 of 7 tasks
zetlen opened this issue Aug 26, 2019 · 0 comments · Fixed by #1598
Closed
1 of 7 tasks

Code coverage has dropped while Coveralls has been disabled #1597

zetlen opened this issue Aug 26, 2019 · 0 comments · Fixed by #1598
Assignees
@zetlen
Labels
bug Something isn't working

Comments

@zetlen
Copy link
Contributor

zetlen commented Aug 26, 2019

Describe the bug
Since we are waiting for Coveralls to be re-enabled after the repo migration, we have to be extra vigilant about code coverage. Especially me.

To Reproduce
Run a full test suite and observe that coverage has declined below 76%.

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zetlen zetlen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zetlen/buildpack v4 test coverage magento/pwa-studio
1 participant
@zetlen