Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc]: Tests for sw.js #1789

Closed
1 of 7 tasks
revanth0212 opened this issue Sep 26, 2019 · 2 comments · Fixed by #1965
Closed
1 of 7 tasks

[misc]: Tests for sw.js #1789

revanth0212 opened this issue Sep 26, 2019 · 2 comments · Fixed by #1965
Assignees
@revanth0212
Labels
enhancement New feature or request performance Things related to perf
Milestone
Performance Optim...

Comments

@revanth0212
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Related to #1673

Describe the solution you'd like
Write tests for sw.js. Now that a lot of things will be changing relative to current sw.js, having tests will help.

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@revanth0212 revanth0212 added the enhancement New feature or request label Sep 26, 2019
@zetlen
Copy link
Contributor

zetlen commented Sep 27, 2019

https://hackernoon.com/service-worker-testing-made-easy-9a2d8e9aa50 might be a good start.

@revanth0212 revanth0212 added the performance Things related to perf label Sep 30, 2019
@cherdman
Copy link
Contributor

https://jira.corp.magento.com/browse/PWA-71

@revanth0212 revanth0212 mentioned this issue Oct 18, 2019
Merged
@revanth0212 revanth0212 self-assigned this Nov 5, 2019
@revanth0212 revanth0212 mentioned this issue Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revanth0212 revanth0212

Labels
enhancement New feature or request performance Things related to perf
Projects
None yet
Milestone
Performance Optimization (Application)
Development

Successfully merging a pull request may close this issue.

Tests for Service Worker magento/pwa-studio
3 participants
@zetlen @revanth0212 @cherdman