Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: browser back buttons isn't responsive #3077

Closed
1 of 7 tasks
Jordaneisenburger opened this issue Mar 22, 2021 · 3 comments · Fixed by #3078
Closed
1 of 7 tasks

[bug]: browser back buttons isn't responsive #3077

Jordaneisenburger opened this issue Mar 22, 2021 · 3 comments · Fixed by #3078
Assignees
Labels
bug Something isn't working Progress: done

Comments

@Jordaneisenburger
Copy link
Member

Jordaneisenburger commented Mar 22, 2021

Describe the bug

The browser back button isn't responding properly when a user clicks the button.

To reproduce

Steps to reproduce the behavior:

  1. Go to <https://venia.magento.com/default/venia-tops/venia-blouses.html?page=1]
  2. Add some filters
  3. Now click on the browser back button once
  4. You should see nothing changed and we are still on the same url.

Expected behavior

When a user clicks the back button they expect to be routed back to the previous page/state

Screenshots

Possible solutions

Check PR ....

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version [e.g Magento Commerce 2.4]:

[!-- Complete the following sections to help us apply appropriate labels! --]

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • [ > create-pwa

Test Plan

  • Go to a category page
  • Add a filter
  • See the results change
  • Use the browser back button to click once
  • Url should change to the previous history state
@Jordaneisenburger Jordaneisenburger added the bug Something isn't working label Mar 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 22, 2021

Hi @Jordaneisenburger. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@sirugh
Copy link
Contributor

sirugh commented Mar 22, 2021

@magento export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1594) is successfully created for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Progress: done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants