-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Certain talons and hooks cannot be wrapped #3873
Comments
Hi @JustinConabreeAbsolunet. Thank you for your report. Add a comment to assign the issue:
|
@magento I am working on this |
Hi @JustinConabreeAbsolunet! 👋 |
@magento add to contributors team |
Hi @JustinConabreeAbsolunet! 👋 |
@magento add to contributors team |
@magento export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.magento.com/browse/PWA-2899 is successfully created for this GitHub issue. |
Describe the bug
Peregrine exposes its talons and hooks based on the file name. If the talon or hook does not export a variable with the same name, wrapping causes the error below. There are a select few that export default instead of a named variable.
To reproduce
Steps to reproduce the behavior:
Expected behavior
No error thrown for any talon or hook
Possible solutions
Export named variables across all talons and hooks
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: