Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWADevServer should be configurable to skip trust settings and hostfile update #8

Closed
PWAStudioBot opened this issue Jun 13, 2018 · 1 comment
Closed

PWADevServer should be configurable to skip trust settings and hostfile update #8

PWAStudioBot opened this issue Jun 13, 2018 · 1 comment
Assignees
@zetlen
Labels
bug Something isn't working help wanted Eligible for community contribution. pkg:pwa-buildpack
Milestone
Sprint 22

Comments

@PWAStudioBot
Copy link
Contributor

From @zetlen on May 16, 2018 20:41

PWADevServer attempts to ensure OS-level trust of its managed SSL certificates, using @magento/devcert. There may be cases, especially in non-interactive build environments that still run development mode, where we want to skip trust settings.

PWADevServer also attempts to update the hostfile, which requires elevated permissions. This should also be skippable.

Steps to reproduce:

  1. Add PWADevServer to a webpack.config file.
  2. Run webpack in a non-interactive process.

Expected results: Dev mode initializes.
Actual results: Hangs forever during PWADevServer instantiation.

Copied from original issue: magento-research/pwa-buildpack#36
@PWAStudioBot PWAStudioBot mentioned this issue Jun 13, 2018
Closed
@DrewML DrewML added bug Something isn't working help wanted Eligible for community contribution. pkg:pwa-buildpack labels Jun 14, 2018
@ericerway ericerway added this to the Sprint 21 milestone Jul 19, 2018
@zetlen zetlen closed this as completed Jul 31, 2018
@zetlen zetlen reopened this Jul 31, 2018
@ericerway
Copy link

Review carried to Sprint 22.

@ericerway ericerway modified the milestones: Sprint 21, Sprint 22 Aug 9, 2018
@zetlen zetlen mentioned this issue Aug 10, 2018
Merged
@awilcoxa awilcoxa mentioned this issue Dec 20, 2018
Closed
7 tasks
fnhipster referenced this issue in PMET-public/pwa-studio Apr 9, 2019
@DrewML
Id tracking (#8)
de95865 
* Add "rootModuleID" field to manifest

* Test cleanup

* Stop clearing moduleByPath Map - results need to persist in watch mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zetlen zetlen

Labels
bug Something isn't working help wanted Eligible for community contribution. pkg:pwa-buildpack
Projects
None yet
Milestone
Sprint 22
Development

No branches or pull requests
4 participants
@zetlen @ericerway @DrewML @PWAStudioBot