Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark interfaces and blocks as API #290

Closed
sivaschenko opened this issue Feb 9, 2021 · 6 comments
Closed

Mark interfaces and blocks as API #290

sivaschenko opened this issue Feb 9, 2021 · 6 comments
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021 •
edited
Loading

The following interfaces and blocks should be marked as API in future-develop branch

  1. security-package/TwoFactorAuth/Api/AdminTokenServiceInterface.php
  2. security-package/TwoFactorAuth/Api/AuthyAuthenticateInterface.php
  3. security-package/TwoFactorAuth/Api/AuthyConfigureInterface.php
  4. security-package/TwoFactorAuth/Api/CountryRepositoryInterface.php
  5. security-package/TwoFactorAuth/Api/Data/AdminTokenResponseInterface.php
  6. security-package/TwoFactorAuth/Api/Data/AuthyDeviceInterface.php
  7. security-package/TwoFactorAuth/Api/Data/AuthyRegistrationPromptResponseInterface.php
  8. security-package/TwoFactorAuth/Api/Data/CountryInterface.php
  9. security-package/TwoFactorAuth/Api/Data/CountrySearchResultsInterface.php
  10. security-package/TwoFactorAuth/Api/Data/DuoDataInterface.php
  11. security-package/TwoFactorAuth/Api/Data/GoogleAuthenticateInterface.php
  12. security-package/TwoFactorAuth/Api/Data/GoogleConfigureInterface.php
  13. security-package/TwoFactorAuth/Api/Data/U2fWebAuthnRequestInterface.php
  14. security-package/TwoFactorAuth/Api/Data/UserConfigInterface.php
  15. security-package/TwoFactorAuth/Api/Data/UserConfigSearchResultsInterface.php
  16. security-package/TwoFactorAuth/Api/DuoAuthenticateInterface.php
  17. security-package/TwoFactorAuth/Api/DuoConfigureInterface.php
  18. security-package/TwoFactorAuth/Api/EngineInterface.php
  19. security-package/TwoFactorAuth/Api/Exception/NotificationExceptionInterface.php
  20. security-package/TwoFactorAuth/Api/GoogleAuthenticateInterface.php
  21. security-package/TwoFactorAuth/Api/GoogleConfigureInterface.php
  22. security-package/TwoFactorAuth/Api/ProviderInterface.php
  23. security-package/TwoFactorAuth/Api/ProviderPoolInterface.php
  24. security-package/TwoFactorAuth/Api/TfaInterface.php
  25. security-package/TwoFactorAuth/Api/TfaSessionInterface.php
  26. security-package/TwoFactorAuth/Api/TfatActionsInterface.php
  27. security-package/TwoFactorAuth/Api/U2fKeyAuthenticateInterface.php
  28. security-package/TwoFactorAuth/Api/U2fKeyConfigReaderInterface.php
  29. security-package/TwoFactorAuth/Api/U2fKeyConfigureInterface.php
  30. security-package/TwoFactorAuth/Api/UserConfigManagerInterface.php
  31. security-package/TwoFactorAuth/Api/UserConfigRepositoryInterface.php
  32. security-package/TwoFactorAuth/Api/UserConfigRequestManagerInterface.php
  33. security-package/TwoFactorAuth/Api/UserConfigTokenManagerInterface.php
  34. security-package/TwoFactorAuth/Api/UserNotifierInterface.php
  35. security-package/TwoFactorAuth/Model/AlertInterface.php
  36. Magento\TwoFactorAuth\Block\ConfigureLater
  37. Magento\TwoFactorAuth\Block\Configure
  38. Magento\TwoFactorAuth\Block\Provider\U2fKey\Configure
  39. Magento\TwoFactorAuth\Block\Provider\U2fKey\Auth
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko mentioned this issue Feb 9, 2021
Open
@sivaschenko sivaschenko changed the title Mark interfaces as API Mark interfaces and blocks as API Feb 9, 2021
@nathanjosiah
Copy link
Contributor

@magento export issue to Jira project MC as Story

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/MC-40870) is successfully created for this issue.

@AndreyChorniy
Copy link

@magento I am working on this

@AndreyChorniy AndreyChorniy mentioned this issue Mar 30, 2021
Closed
5 tasks
@nathanjosiah
Copy link
Contributor

fixed in https://github.com/magento-commerce/security-package/pull/38

@fredden
Copy link
Member

fredden commented Jul 21, 2021

fixed in https://github.com/magento-commerce/security-package/pull/38

8d5c176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fredden @nathanjosiah @sivaschenko @AndreyChorniy @github-jira-sync-bot