Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offhand damage calculation #18

Open
krangerich opened this issue Jun 11, 2019 · 1 comment
Open

Offhand damage calculation #18

krangerich opened this issue Jun 11, 2019 · 1 comment

Comments

@krangerich
Copy link

Don't know, if this is relevant or belongs here, but while building my warrior spreadsheet, I noticed the following:

When calculating the min/max damage from a offhand weapon, the attack power used in this calculation is being rounded to the next multiple of 4.

Basic formula (without talents for simplicity):
oh_min_dmg = (attack_power/14*oh_speed + oh_min_weapon_dmg) * 50%

387, 388 or 389 attack power will lead to the same value (determined using UnitDamage("player")).

Mainhand damage doesn't seem to be affected this way

@Malchar
Copy link

Malchar commented Jul 3, 2019

Based on some limited testing on Kronos 3, I believe that the formula on Kronos 3 might be something like this:

oh_min_dmg = floor(oh_min_weapon_dmg * 50%) + floor(attack_power / 14 * oh_speed * 50%)

I haven't thought about it too hard, but it's possible that flooring both components separately could account for the strange "multiple of 4" rounding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants