Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devastate has incorrect tooltip #47

Closed
mechanicsTBC opened this issue Apr 7, 2021 · 2 comments
Closed

Devastate has incorrect tooltip #47

mechanicsTBC opened this issue Apr 7, 2021 · 2 comments
Assignees
Labels
Bug Something isn't working Fixed Fixed on current beta build

Comments

@mechanicsTBC
Copy link

mechanicsTBC commented Apr 7, 2021

devastate-bug
These two values have been swapped, possibly only in the tooltip.
the spell data shows it having proper formula of:

Effect 1 | Weapon Damage - %
Value: 50

Effect 2 | Normalized Weapon Damage
Value: 35

so I assume this is just a tooltip error.

@magey magey changed the title Devastate dealing incorrect weapon damage Devastate has incorrect tooltip Apr 7, 2021
@magey magey added the Bug Something isn't working label Apr 7, 2021
@magey magey self-assigned this Apr 7, 2021
@magey
Copy link
Owner

magey commented Apr 7, 2021

It's only a tooltip error, possibly because the effects of the spell are in the reverse order in the classic TBC game files; the text of the tooltip comes from a kind-of format string like this: Sunder the target's armor causing the Sunder Armor effect. In addition, causes $s2% of weapon damage plus $s3 for each application of Sunder Armor on the target. The Sunder Armor effect can stack up to $u times. where $s2 is replaced by the value of 2nd effect and $s3 by the value of the 3rd effect (the first effect is empty in the case of Devastate in the original 2.4.3 files).

Here's proof from in-game that it deals the correct damage:

image

Using a Shortsword (2.60 speed 2-4 damage) and one-handed specialization, the theoretical weapon damage of Devastate rank 1 (50% + 15 * num_sunders) on an un-sundered target would approximately be (before rounding of certain parts of these equations by the game):

AP_contribution = 666/14*2.4
Min_damage = (AP_contribution + 2) * 0.5 * 1.1 = 63.894...
Max_damage = (AP_contribution + 4) * 0.5 * 1.1 = 64.994...

And for 5 sunders:

Min_damage = ((AP_contribution + 2) * 0.5 + 15*5) * 1.1 = 146.394...
Max_damage = ((AP_contribution + 4) * 0.5 + 15*5) * 1.1 = 147.494...

The dummies have near zero armor so it should be very close to these values, and indeed:

image

image

I've changed the title of this issue accordingly.

@magey magey added the Fixed Fixed on current beta build label Apr 19, 2021
@magey
Copy link
Owner

magey commented Apr 19, 2021

Fixed in 2.5.1.38364

@magey magey closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed Fixed on current beta build
Projects
None yet
Development

No branches or pull requests

2 participants