fix: ensure that the minified esm file is loaded from unpkg #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeijer
force-pushed
the
feature/fix-unpkg
branch
from
d89cfb2
to
83fdce9
Compare
3v0k4
approved these changes
Nov 9, 2022
3v0k4
approved these changes
Nov 9, 2022
3v0k4
approved these changes
Nov 9, 2022
Merged
smeijer
pushed a commit
that referenced
this pull request
Nov 9, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @magicbell/embeddable@3.2.4 ### Patch Changes - [#15](#15) [`7767b69`](7767b69) Thanks [@smeijer](https://github.com/smeijer)! - ensure that the minified esm bundle is imported when importing from unpkg. - Updated dependencies \[[`1cb984c`](1cb984c)]: - @magicbell/magicbell-react@10.3.3 ## @magicbell/magicbell-react@10.3.3 ### Patch Changes - [#13](#13) [`1cb984c`](1cb984c) Thanks [@3v0k4](https://github.com/3v0k4)! - Fix embeddable web notifications: since embeddable aliases axios (redaxios) and redaxios does not implement `.getUri`, the code was failing for the embeddable package (that uses redaxios) but not for the react package (that uses axios). Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the unpkg esm import when used like: