-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for default Hasura types #93
Comments
Looking at Hasura types, some of the example here seem inacurate. For example, |
@pelletier197 you're right but the query accepts both integer and string as a value this will work: query MyQuery($total_likes: bigint = 3) {
comment(where: {total_comment_likes: {_gte: $total_likes}}) {
author_id
}
} also this does work: query MyQuery($total_likes: bigint = "3") {
comment(where: {total_comment_likes: {_gte: $total_likes}}) {
author_id
}
} Hasura has some weird types but we should stick with their docs, we should treat |
Alright. I'll be honest though, it' s a little weird to implement some of these types as string. For instance, another user could have a I think it makes sense to implement some of these with a natural default value.
However, some of these make less sense:
So I would implement all of these using the natural way if you're fine with it. If the type is ever not like you'd want too, you can always override it. Does that seem fair to you? |
Yeah, seems totally fair! |
Default Hasura types should be supported by query generation factories by default
See #92 for more details.
The text was updated successfully, but these errors were encountered: