Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(require 'magit) fails with Symbol's value as variable is void: magit-log-edit-confirm-cancellation #789

Closed
dinojr opened this issue Aug 21, 2013 · 2 comments
Labels
invalid This doesn't seem right
Milestone

Comments

@dinojr
Copy link

dinojr commented Aug 21, 2013

It seems magit-log-edit-confirm-cancellation is defined after (defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)

in magithub.el

@praet
Copy link
Contributor

praet commented Aug 21, 2013

On Tue, 20 Aug 2013 22:15:35 -0700, Julien Cubizolles notifications@github.com wrote:

It seems magit-log-edit-confirm-cancellation is defined after (defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)

in magithub.el

That's an issue in magithub, not in Magit.

Reported in nex3/magithub#11 and reportedly fixed in nex3/magithub#12.

Peace

Pieter

@tarsius
Copy link
Member

tarsius commented Jan 2, 2014

Because upstream doesn't fix it, magithub has been removed from melpa: melpa/melpa#1126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants