Merge remote-tracking branch 'upstream/master' into feat/text-autocomplete

Author: WilliamVenner

.github/workflows/constraints.txt

@@ -1,5 +1,5 @@
-pip==22.2.2
+pip==22.3.1
 nox==2022.8.7
-nox-poetry==1.0.1
+nox-poetry==1.0.2
 poetry==1.1.15
-virtualenv==20.16.5
+virtualenv==20.16.6

.github/workflows/documentation.yml

@@ -18,8 +18,8 @@ jobs:
     name: Build documentation & check links
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3.0.2
-      - uses: actions/setup-python@v4.2.0
+      - uses: actions/checkout@v3.1.0
+      - uses: actions/setup-python@v4.3.0
         with:
           python-version: "3.10"
 
@@ -40,7 +40,7 @@ jobs:
         run: nox --force-color --session=docs-build
 
       - name: Upload documentation
-        uses: actions/upload-artifact@v3.1.0
+        uses: actions/upload-artifact@v3.1.1
         with:
           name: docs
           path: docs/_build

.github/workflows/labeler.yml

@@ -12,9 +12,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out the repository
-        uses: actions/checkout@v3.0.2
+        uses: actions/checkout@v3.1.0
 
       - name: Run Labeler
-        uses: crazy-max/ghaction-github-labeler@v4.0.0
+        uses: crazy-max/ghaction-github-labeler@v4.1.0
         with:
           skip-delete: true

.github/workflows/release.yml

@@ -13,12 +13,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out the repository
-        uses: actions/checkout@v3.0.2
+        uses: actions/checkout@v3.1.0
         with:
           fetch-depth: 2
 
       - name: Set up Python
-        uses: actions/setup-python@v4.2.0
+        uses: actions/setup-python@v4.3.0
         with:
           python-version: "3.10"
 
@@ -64,7 +64,7 @@ jobs:
           password: ${{ secrets.PYPI_API_TOKEN }}
 
       - name: Publish the release notes
-        uses: release-drafter/release-drafter@v5.21.0
+        uses: release-drafter/release-drafter@v5.21.1
         with:
           publish: ${{ steps.check-version.outputs.tag != '' }}
           tag: ${{ steps.check-version.outputs.tag }}

.github/workflows/tests.yml

@@ -28,10 +28,10 @@ jobs:
 
     steps:
       - name: Check out the repository
-        uses: actions/checkout@v3.0.2
+        uses: actions/checkout@v3.1.0
 
       - name: Set up Python ${{ matrix.python }}
-        uses: actions/setup-python@v4.2.0
+        uses: actions/setup-python@v4.3.0
         with:
           python-version: ${{ matrix.python }}
 
@@ -73,7 +73,7 @@ jobs:
           print("::set-output name=result::{}".format(result))
 
       - name: Restore pre-commit cache
-        uses: actions/cache@v3.0.8
+        uses: actions/cache@v3.0.11
         if: matrix.session == 'pre-commit'
         with:
           path: ~/.cache/pre-commit
@@ -87,7 +87,7 @@ jobs:
 
       - name: Upload coverage data
         if: always() && matrix.session == 'tests'
-        uses: "actions/upload-artifact@v3.1.0"
+        uses: "actions/upload-artifact@v3.1.1"
         with:
           name: coverage-data
           path: ".coverage.*"
@@ -97,10 +97,10 @@ jobs:
     needs: tests
     steps:
       - name: Check out the repository
-        uses: actions/checkout@v3.0.2
+        uses: actions/checkout@v3.1.0
 
       - name: Set up Python
-        uses: actions/setup-python@v4.2.0
+        uses: actions/setup-python@v4.3.0
         with:
           python-version: "3.10"
 

docs/requirements.txt

@@ -1,2 +1,2 @@
-furo==2022.9.15
-sphinx==5.2.2
+furo==2022.9.29
+sphinx==5.3.0

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "inquirer"
-version = "2.10.0"
+version = "2.10.1"
 description = "Collection of common interactive command line user interfaces, based on Inquirer.js"
 authors = ["Miguel Ángel García <miguelangel.garcia@gmail.com>"]
 license = "MIT"

src/inquirer/questions.py

@@ -44,19 +44,18 @@ def __init__(
         show_default=False,
         other=False,
     ):
-        if other:
-            choices = choices or []
-            choices.append(GLOBAL_OTHER_CHOICE)
-
         self.name = name
-        self._other = other
         self._message = message
         self._choices = choices or []
         self._default = default
         self._ignore = ignore
         self._validate = validate
         self.answers = {}
         self.show_default = show_default
+        self._other = other
+
+        if self._other:
+            self._choices.append(GLOBAL_OTHER_CHOICE)
 
     def add_choice(self, choice):
         try:

src/inquirer/render/console/_other.py

@@ -1,6 +1,6 @@
 class OtherChoice:
     def __str__(self):
-        return "Other..."
+        return "Other"
 
 
 GLOBAL_OTHER_CHOICE = OtherChoice()

src/inquirer/themes.py

@@ -89,10 +89,10 @@ def __init__(self):
         self.Editor.opening_prompt_color = term.bright_black
         self.Checkbox.selection_color = term.blue
         self.Checkbox.selection_icon = ">"
-        self.Checkbox.selected_icon = "X"
+        self.Checkbox.selected_icon = "[X]"
         self.Checkbox.selected_color = term.yellow + term.bold
         self.Checkbox.unselected_color = term.normal
-        self.Checkbox.unselected_icon = "o"
+        self.Checkbox.unselected_icon = "[ ]"
         self.List.selection_color = term.blue
         self.List.selection_cursor = ">"
         self.List.unselected_color = term.normal