Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid return type in shipping price calculation #144

Closed
swimmer-zone opened this issue Mar 3, 2022 · 2 comments
Closed

Invalid return type in shipping price calculation #144

swimmer-zone opened this issue Mar 3, 2022 · 2 comments

Comments

@swimmer-zone
Copy link

Orders aren't added to the sales_order table, because of the following error:

Return value of Magmodules\Channable\Service\Order\Shipping\CalculatePrice::execute() must be of the type float, string returned in /vendor/magmodules/magento2-channable/Service/Order/Shipping/CalculatePrice.php:67

Proposed solution:
Change line 67 from return $shippingPriceCal; to return (float) $shippingPriceCal;

@swimmer-zone
Copy link
Author

I see that there's already a PR pending for this issue: c857c8e, sorry for this one :)

@Marvin-Magmodules
Copy link
Member

HI @swimmer-zone,

Thank you for opening this issue, we are happy to share that we've just released the new v1.6.2 version where we covered this issue. Thank you for the detailed issue report.

We are closing this issue now but please feel free to reopen the issue if this still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants