Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by zero. Service/Order/Shipping/CalculatePrice.php:75 #219

Closed
yuriichayka opened this issue Mar 18, 2024 · 2 comments
Closed

Division by zero. Service/Order/Shipping/CalculatePrice.php:75 #219

yuriichayka opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
Fixed and planned for next release Fix will be included in the next release.

Comments

@yuriichayka
Copy link

Version - 1.17.0
if the shipping price equals "0" - the error occurs
It wasn't the case in previous versions, happens due to recent modifications of the file

Example of the price request node:
"price" => [
"payment_method" => "amazon",
"currency" => "GBP",
"subtotal" => "83.64",
"shipping" => "0",
"total" => "83.64",
"transaction_fee" => "0.00",
"commission" => "0.00",
"discount" => "0.00"
]

Error:
report.CRITICAL: DivisionByZeroError: Division by zero in /app/xxx/vendor/magmodules/magento2-channable/Service/Order/Shipping/CalculatePrice.php:75

@Frank-Magmodules Frank-Magmodules added the Investigating We are working on this issue together with the customer. label Mar 19, 2024
@Frank-Magmodules
Copy link
Member

Hello there @yuriichayka , we're happy to inform you that we've identified this issue and will include the fix in the next release. I'll leave the issue open for now and will confirm the release within this ticket at that time.

@Frank-Magmodules Frank-Magmodules self-assigned this Mar 21, 2024
@Frank-Magmodules Frank-Magmodules added Fixed and planned for next release Fix will be included in the next release. and removed Investigating We are working on this issue together with the customer. labels Mar 21, 2024
@Frank-Magmodules
Copy link
Member

Hi There @yuriichayka , Thank you once more for bringing this issue to our attention and providing the necessary information. We're happy to inform you that we have addressed this matter in our latest release I'm marking this issue as resolved for now. Please don't hesitate to reopen it if necessary. Thank you again for your cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed and planned for next release Fix will be included in the next release.
Projects
None yet
Development

No branches or pull requests

2 participants