Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Discount not included on invoice #227

Closed
Skullsneeze opened this issue May 30, 2024 · 1 comment
Closed

[BUG] Discount not included on invoice #227

Skullsneeze opened this issue May 30, 2024 · 1 comment

Comments

@Skullsneeze
Copy link
Contributor

Description

When syncing an order with a discount the discount is applied to the order grand total, but is not reflected in the total paid on the invoice.

Steps to reproduce

  • Enable and configure order imports
  • Ensure invoice creation is enabled
  • Import an order with a discount.

Expected result

  • The order is imported
  • The invoice is created
  • The discount is applied on both the order and the invoice

Actual result

  • The order is imported
  • The invoice is created
  • The discount is applied on the order
  • The discount is not applied on the invoice

Related PR

I've opened PR #226 which resolved the issue for me on our test environment. It explicitly adds the discount information to the invoice during creation.

@Marvin-Magmodules
Copy link
Member

Hello @Skullsneeze, we appreciate you bringing this issue to our attention and thank you for opening up an PR for this!

I'm happy to inform you that we've released a new version of the plugin addressing the reported issue and merged this PR. Since I believe this update resolves your concern, I'm closing the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants