Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install gets 20 Duplicate definition and declaration #208

Open
shawnmacburnie opened this issue Feb 6, 2017 · 13 comments
Open

Fresh install gets 20 Duplicate definition and declaration #208

shawnmacburnie opened this issue Feb 6, 2017 · 13 comments

Comments

@shawnmacburnie
Copy link

With a brand new fresh install of React-native@0.40.0 getting 20 errors from RCTFBLogin about duplicate definitions and declarations. At the very bottom of all the errors there is an error Apple LLVM 8.0 error but just says "too many errors emitted, stopping now".

screen shot 2017-02-06 at 6 30 49 pm

@seoyoungrag
Copy link

i got the same problem ..........

@antonioromano
Copy link

Me too

@hugheba
Copy link

hugheba commented Feb 8, 2017

+1

@gkueny
Copy link

gkueny commented Feb 10, 2017

I think it's an issue with RN 0.40.0. To fix this, try to install npm module like this :

npm install github:magus/react-native-facebook-login --save

You will install the master version which contain support for RN 0.40.0. That's worked for me and saved my night.

(Sorry for my bad english)

@aliechihabi
Copy link

aliechihabi commented Feb 10, 2017

Hi All,

I followed the resolution of the following issue and it did the trick for me:
facebook/react-native#11725

In addition to RCTBridge, apply to RCTLog and other duplicate definitions.
I recommend doing it manually and building after each replacement from "RCTLog.h" to <React/RCTLog.h> for example and see if the number of errors decreases (hence going in the right direction).

I went from 30 errors, to 18, to 7 to 1 to none.
Start with the classes under RCTFBLogin.xcodeproj

Sample class after changes:

RCTFBLoginManager.m includes:
#import <FBSDKCoreKit/FBSDKCoreKit.h>
#import <FBSDKLoginKit/FBSDKLoginKit.h>
#import <React/RCTBridge.h>
#import <React/RCTEventDispatcher.h>
#import <React/RCTLog.h>

#import "RCTFBLogin.h"
#import "RCTFBLoginManager.h"

Good luck amigos.

@lwhiteley
Copy link
Contributor

lwhiteley commented Feb 10, 2017

these fixes are in master i presume

https://github.com/magus/react-native-facebook-login/pull/196/files

However not published to npm

so follow @gkueny's advice.

npm install github:magus/react-native-facebook-login --save

@Naoto-Ida
Copy link

Naoto-Ida commented Feb 21, 2017

Might not really be related to this issue per se, but npm install github:magus/react-native-facebook-login --save just hangs for me.

@Fantasim
Copy link

@Naoto-Ida hangs for me too :/

@Naoto-Ida
Copy link

@Fantasim I just git cloned in a closeby directory and specified it as a local dependency to work around it.

@Fantasim
Copy link

Fantasim commented Feb 21, 2017

@Naoto-Ida Yes i did that, @magus is it possible to fix that with npm?

@leaky
Copy link

leaky commented Feb 21, 2017

I encountered the above and npm install github:magus/react-native-facebook-login --save did do the trick. It's true that it just hangs but if you just wait, eventually the module will get installed. (I waited around 2mins)

@Naoto-Ida
Copy link

Ah, my impatience got the better of me. I left it running and got it to install.

@giftedunicorn
Copy link

npm install github:magus/react-native-facebook-login --save
This really solved my problem. Asking the right question is also so important and time saving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests