Index out of bound on SuggestionDirection.up

[muhammad-hassan-shakeel]

Describe the bug
After setting suggestionDirection = SuggestionDirection.up, tapping an element from suggestion list throws index out of bound exception

To Reproduce
Steps to reproduce the behavior:

1. Add suggestionDirection: SuggestionDirection.up in the searchfield widget.
2. Run the example application (I tried on the web)
3. Tap on the search field
4. Select any element from the suggestion list
5. the element won't appear selected on the text field and console will show index out of bound exception
   [Yes] By clicking this checkbox, I confirm I am using the latest version of the package found on pub.dev/searchfield

Expected behavior
Element from suggestions should get selected and show on the text field without index out of bound exception.

Actual behavior
Element from suggestions doesn't get selected and throws index out of bound exception.

Screenshots
If applicable, add screenshots to help explain your problem.

Code sample

Show code sample

// import 'package:example/pagination.dart';
import 'package:flutter/material.dart';
import 'package:searchfield/searchfield.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter App',
      theme: ThemeData(
        colorSchemeSeed: Colors.indigo,
        useMaterial3: true,
        brightness: Brightness.light,
      ),
      darkTheme: ThemeData(
        colorSchemeSeed: Colors.blue,
        useMaterial3: true,
        brightness: Brightness.dark,
      ),
      home: SearchFieldSample(),
      debugShowCheckedModeBanner: false,
    );
  }
}

class SearchFieldSample extends StatefulWidget {
  const SearchFieldSample({Key? key}) : super(key: key);

  @override
  State<SearchFieldSample> createState() => _SearchFieldSampleState();
}

class _SearchFieldSampleState extends State<SearchFieldSample> {
  @override
  void initState() {
    suggestions = [
      'United States',
      'Germany',
      'Canada',
      'United Kingdom',
      'France',
      'Italy',
      'Spain',
      'Australia',
      'India',
      'China',
      'Japan',
      'Brazil',
      'South Africa',
      'Mexico',
      'Argentina',
      'Russia',
      'Indonesia',
      'Turkey',
      'Saudi Arabia',
      'Nigeria',
      'Egypt',
    ];
    super.initState();
  }

  var suggestions = <String>[];
  var selectedValue = null;
  @override
  Widget build(BuildContext context) {
    Widget searchChild(x, {bool isSelected = false}) => Padding(
          padding: const EdgeInsets.symmetric(horizontal: 12),
          child: Text(x,
              style: TextStyle(
                  fontSize: 18,
                  color: isSelected ? Colors.green : Colors.black)),
        );
    return Scaffold(
        appBar: AppBar(title: Text('Searchfield Demo test')),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            spacing: 20,
            children: [
              SearchField(
                hint: 'Basic SearchField',
                dynamicHeight: true,
                maxSuggestionBoxHeight: 300,
                suggestionDirection: SuggestionDirection.up,
                onSuggestionTap: (SearchFieldListItem<String> item) {
                  setState(() {
                    selectedValue = item;
                  });
                },
                selectedValue: selectedValue,
                suggestions: suggestions
                    .map(
                      (x) => SearchFieldListItem<String>(
                        x,
                        item: x,
                        child: searchChild(x),
                      ),
                    )
                    .toList(),
                suggestionState: Suggestion.expand,
              ),
            ],
          ),
        ));
  }
}

Additional context
Add any other context about the problem here.

[maheshj01]

Thanks for filing the issue and I really appreciate the PR. I was able to reproduce the issue.

[maheshj01]

Fixed and released in v1.2.4
Thank you for your contribution @muhammad-hassan-shakeel