Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evm integration step 4 #2149

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

mickvandijke
Copy link
Contributor

@mickvandijke mickvandijke commented Sep 26, 2024

Will merge the EVM autonomi API in without breaking the native autonomi API. Introduces feature flags for autonomi: native-payments and evm-payments.

autonomi::Client will default to autonomi::native::Client when using native-payments and to autonomi::evm::Client when using evm-payments.

TODO:

  • Make Client more generic to be used by a EvmClient and NativeClient.
  • Fix visibility.
  • Fix feature flags.
  • Update docs.

Requires:

…m_integration_step_4

# Conflicts:
#	Cargo.lock
#	autonomi/Cargo.toml
#	autonomi/src/client/data.rs
#	autonomi/src/client/registers.rs
#	autonomi/src/lib.rs
#	autonomi/src/native/client/transfers.rs
#	autonomi/src/native/secrets.rs
#	autonomi/src/native/wallet/mod.rs
#	autonomi/tests/common/mod.rs
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@mickvandijke mickvandijke marked this pull request as ready for review September 29, 2024 18:51
@mickvandijke mickvandijke changed the base branch from main to evm-dev September 30, 2024 07:15
@mickvandijke mickvandijke changed the base branch from evm-dev to main September 30, 2024 07:22
@mickvandijke mickvandijke changed the base branch from main to evm-dev September 30, 2024 07:23
@mickvandijke mickvandijke merged commit bceb5ac into maidsafe:evm-dev Sep 30, 2024
7 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants