feat: adapt node manager add
command for evm network
#2235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
c276fb2 feat: configure anvil to listen on non-local address
For use in a remote network, Anvil must listen on the public IP address of the VM it is running on.
The
anvil
binary respects theANVIL_IP_ADDR
variable for configuring a listener address.However, it turns out the
alloy
crate is actually hard coded to work with "localhost", sounfortunately the
AnvilInstance::endpoint
function cannot be used to return the resulting RPC URL.For that reason, a new
rpc_url
field was added to theTestnet
struct to keep track of thenon-local listening address.
The deployer wallet private key was also saved in the CSV data because it will be necessary for
testnet-deploy
to obtain this.edd5103 feat: adapt node manager
add
command for evm networkBREAKING CHANGE: services configured by the node manager are no longer compatible with networks that
are not EVM.
The node manager
add
command now supports the following EVM arguments:evm-custom
subcommand makes the--data-payments-address
,--payment-token-address
and--rpc-url
arguments available.--rewards-address
argument is provided.The
CustomNetwork
type was modified to enable it to be serialized in the node manager registry.Type of Change
Please mark the types of changes made in this pull request.