feat: private data, private archives, vault support and CLI integration #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
commented
Oct 25, 2024
Comment on lines
+35
to
+38
| /// Get a private address for [`PrivateDataAccess`]. Note that this is not a network address, it is only used for refering to private data client side. | ||
| pub fn address(&self) -> String { | ||
| hash_to_short_string(&self.to_hex()) | ||
| } |
There was a problem hiding this comment.
This is kind of an important design decision. Wanted to outline this here. Public data refers to a Network address which points to a DataMap. PrivateDataAccess is not an address it IS THE DATAMAP. As it it can be very big (up to max chunk size), we need a way to refer to it in the client side, thus using its hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that unlike public data, private data can only be downloaded by the owner! Either from the same client (needs local user data) OR from another client with a synced vault! Here's the flow: