Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove env var requirement for builds #2422

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

dirvine
Copy link
Member

@dirvine dirvine commented Nov 9, 2024

Description

This is a quick fix to remove the requirement for devs to publish static (non changing) env vars when building.

Related Issue

None

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@@ -55,15 +54,40 @@
}
}

/// FIXME: Remove this once BEFORE next breaking release and fix this whole file

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@jacderida jacderida enabled auto-merge November 9, 2024 14:21
@jacderida jacderida disabled auto-merge November 9, 2024 14:30
@jacderida jacderida merged commit 3009b60 into maidsafe:main Nov 9, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants