Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8 compatibility #3

Closed
1 of 5 tasks
Tracked by #37
jeffpaul opened this issue May 29, 2024 · 2 comments · Fixed by #26
Closed
1 of 5 tasks
Tracked by #37

Add PHP 8 compatibility #3

jeffpaul opened this issue May 29, 2024 · 2 comments · Fixed by #26
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Collaborator

jeffpaul commented May 29, 2024

The plugin currently does not set a "Requires PHP", so we'll want to work on testing and adding compatibility for PHP 8 so that we can declare that more formally within the code.

@jeffpaul jeffpaul added the type:enhancement New feature or request. label May 29, 2024
@jeffpaul jeffpaul added this to the 1.6.0 milestone May 29, 2024
@dkotter
Copy link
Collaborator

dkotter commented May 30, 2024

My recommendation here would be the following:

  1. Setup a local environment running PHP 7.4 and run through all plugin functionality, both in the admin and front-end. Take note of any warnings, errors, deprecation notices, etc that get logged and fix those
  2. Update that environment to PHP 8.3 and run through all tests again, making note of any new warnings, errors, deprecations, etc that get logged, fixing those

A good majority of users are still on PHP 7.4 so I think it's worth the small amount of extra effort to test on 7.4 and 8.3. In addition, while we run PHPCompat on most of our plugins it doesn't actually support PHP 8.x+ yet, so that's nice to add but worth noting that we still need to run manually testing to verify PHP 8.x+ compat.

@dkotter
Copy link
Collaborator

dkotter commented Jun 10, 2024

Talking with Mailchimp today, we are going to set PHP 7.0 as our minimum. The hope is to fairly quickly bump that to 7.4 but wanted to have smaller bumps rather than one large one

@nateconley nateconley mentioned this issue Jun 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants