Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the Settings link on the plugin list screen goes to the new top-level settings menu #32

Closed
1 task done
Tracked by #37
dkotter opened this issue Jun 17, 2024 · 0 comments · Fixed by #33
Closed
1 task done
Tracked by #37
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jun 17, 2024

Describe the bug

Once thing I missed during review of #29 is that the Settings link that shows under the plugin on the plugin list screen still points to the old location. That link does work but doesn't properly set the active menu item.

Steps to Reproduce

  1. Go to wp-admin/plugins.php
  2. Click on the Settings link under the Mailchimp plugin
  3. Notice the settings page loads but it doesn't set the proper menu item as active

Screenshots, screen recording, code snippet

Plugin settings link

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants