Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus button in deleteAll modal #16

Open
dmke opened this issue Jun 3, 2016 · 2 comments
Open

Focus button in deleteAll modal #16

dmke opened this issue Jun 3, 2016 · 2 comments
Labels

Comments

@dmke
Copy link

dmke commented Jun 3, 2016

$scope.deleteAll only opens the modal dialog.

Can we set the focus on either the "delete all messages" or the "cancel" button? This would greatly reduce the mileage on my mouse :-)

Example implementation:

$scope.deleteAll = function() {
  $('#confirm-delete-all').modal('show').on("show.bs.modal", function(ev) {
    $(this).find("button:last").focus();
  });
}
@dmke
Copy link
Author

dmke commented Jun 3, 2016

Also, please add the keyboard option, so that hitting Esc closes the dialog (.modal("show", { keyboard: true }).

@ian-kent
Copy link
Member

ian-kent commented Jul 7, 2016

Thanks @dmke - I had a quick look at this, there's something not quite right because none of those things work at all, the stuff underneath the greyed out background still has focus.

The HTML is also a bit broken, the modals are inside a container which leaves the menu at the top active.

I'll see what I can do 😄

@ian-kent ian-kent added the bug label Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants