Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runloop timers in FastBoot #1912

Closed
trek opened this issue Jul 22, 2019 · 1 comment · Fixed by #1919
Closed

runloop timers in FastBoot #1912

trek opened this issue Jul 22, 2019 · 1 comment · Fixed by #1919
Labels

Comments

@trek
Copy link
Contributor

trek commented Jul 22, 2019

We ran into an interesting issue with a combination of OAuth2PasswordGrant, FastBoot, Cookie session store and the runloop:

On app boot and authentication _scheduleAccessTokenRefresh will trigger and set up a timer in FastBoot that appears to continually rescheduled itself.

We additionally ran into a similar issue as fenichelar/ember-simple-auth-token#250 where a very large expires_in value overruns node's 32-bit signed integer max size when attempting to parse the cookie.

(node:15570) TimeoutOverflowWarning: 2591999302267 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.
(node:15570) TimeoutOverflowWarning: 2591999302265 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.
(node:15570) TimeoutOverflowWarning: 2591999302262 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.
(node:15570) TimeoutOverflowWarning: 2591999302259 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.
(node:15570) TimeoutOverflowWarning: 2591999302257 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.

Both are leading us to believe that refreshAccessTokens should never be true (the current default) when run in FastBoot.

Happy to PR if that's the case.

For now, we've set refreshAccessTokens to false.

@marcoow
Copy link
Member

marcoow commented Aug 2, 2019

Thanks for reporting this! Indeed an access token refresh should never be scheduled in FastBoot - PR would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants