Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial in Readme does not use Release Version #2253

Closed
ErvinSabic opened this issue Nov 20, 2020 · 4 comments
Closed

Tutorial in Readme does not use Release Version #2253

ErvinSabic opened this issue Nov 20, 2020 · 4 comments

Comments

@ErvinSabic
Copy link
Contributor

I was pulling my hair out for a while trying to figure out what I was doing wrong while following the tutorial listed on the readme of this repo. :)

If you follow the tutorial the way it is now you will get an error along the lines of this:

Error while processing route: management.users.index this.session.requireAuthentication is not a function TypeError: this.session.requireAuthentication is not a function

I was very confused because I was getting the session service that I was requesting and looking at the source code in the repo the requireAuthentication method should exist. After some help from the EmberJS Discord we found out you need to be using the beta version of ember-simple-auth for this to work. You can get this version via npm by doing npm i ember-simple-auth@3.1.0-beta.1.

We need to update the readme to use this beta.

@ErvinSabic
Copy link
Contributor Author

I have created a pull request #2254

@BryanCrotaz
Copy link
Contributor

The same thing just hit me - I lost a day trying to work out what typo I'd made. I swear every time I upgrade to a new Ember version I spend half my time dealing with ember-simple-auth, and mainly down to documentation issues.

@BryanCrotaz
Copy link
Contributor

And if the beta is good enough for the tutorial, why is it not a release?

@sdebarros
Copy link
Contributor

Fixed in #2254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants