-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-simple-auth is using its own copies of peer-deps like RSVP #2731
Comments
ember-auto-import should be treating rsvp like the rest of the magically-provided ember packages. So if it's getting bundled that's a bug in ember-auto-import (or Whereas if |
rsvp
should be a peer-dep for ember-simple-auth but isn't. I'm not sure if that fix alone would cause ember-auto-import to stop bundling a uniquersvp
version for use by it in its chunk but it may? There's probably something to work out with ember-auto-import here too.Additionally: I am unsure what all embroider addon tooling is supposed to auto populate for externals, but either rsvp isn't in it and should be or ember-simple-auth needs to explicitly declare rsvp and similar as part of externals.
The text was updated successfully, but these errors were encountered: