Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in observer logic #883

Closed
adam-knights opened this issue Feb 3, 2016 · 3 comments
Closed

Possible bug in observer logic #883

adam-knights opened this issue Feb 3, 2016 · 3 comments

Comments

@adam-knights
Copy link

I'm following emberjs/ember.js#12892 - because it relates to a bug that's critical to us.

The pull request mentions that when this code goes into Ember it will likely cause warnings in 2.4 and then assertions in 2.5, the OP found issues with Ember simple auth with his build, and feels it shows up something wrong with the observer logic here.

Opening this issue as a heads up incase there is anything easy to spot early. I had a quick look through the code but couldn't work out what it could be myself. May need to wait for this to go into Canary if its not obvious.

@marcoow
Copy link
Member

marcoow commented Feb 3, 2016

Can you add some more detail? ESA doesn't use observers I think.

@adam-knights
Copy link
Author

Literally just got the info from the pull request at the moment - when this hits Canary I'll be pulling it to test our app anyway, and we use ESA so happy to update or close this issue if all good then?

I may well pull the current pull request today if I get a chance anyway.

@marcoow
Copy link
Member

marcoow commented Feb 25, 2016

Please reopen when there is actually a problem.

@marcoow marcoow closed this as completed Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants