-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add total/selectable print time and filament usage to gcode files panel #1416
Conversation
Thank you for the PR! I only think about it to split the path and the "stats" in separate lines, because the path could be very long. Can you please split it in separate lines? |
I would suggest keepping then filament usage also on mobile. Very helpful to check if enough filament is left if I want to start a job one more time.
I would suggest to hide the state if no job is selected. The UI would be more clean and it can be easily shown if all are selected.
Seperate lines would take a lot of space on mobile, I would rather suggest to shorten the description |
but if you only display it, when files are selected, i see no problem with a separate line. then you have also enough space to display:
and path & free disk space will be in the first line without any change. |
Seems fine for me 👍 |
To make it a second line, there are some downsides as well:
I had considered putting the data in the bottom left, on the same row as the pagination controls, but that would likely create some of the same issue. A third idea I had 🤔, but haven't experimented with, was to move everything "stats" related to a new panel below the file selection panel. This panel would work similar to the way the "History" page does, where there are some graphs, and changing the selection changes the content of the graph. This would be more work, but would get out of the problem of putting too much extra information in the files table, and also allow users to collapse the panel if they didn't want that data.. I'm attaching a (really bad) quick sketch of what I'm takling about. This new panel could have a pie chart of printed vs. not printed, and a table of filament length, filament weight, and print time of the selected files. I'm sure other things could be added in the future as well. |
Is adding the panel with the charts necessary? My main problem with this is that if you don't select any files, mainsail doesn't have all the metadata, but only the metadata from the currently visible files (or metadata pulled since the last refresh). The statistics wouldn't make sense without having a file selected. As an alternative, it would occur to me that you make the two lines above by default and then split them:
|
I like this idea. |
@meteyou |
@EmJay276 this would be nice. otherwise I have to implement this feature, but feel free to create a new PR with this feature. |
Any news here? |
i will close this PR, because of no response... |
Description
This PR adds status labels for total print time and total filament usage to the G-Code Files panel.
The purpose of this feature is to make multi-prints projects easier, either by using the totals at the start of a project, or selecting specific files during a project to make sure enough filament remains or to assess how much total time is remaining.
There were several places this data could go, and after 3 iterations and feedback from fellow Mainsail users, I chose to locate it in the top right. The reason for this was twofold:
Adding more data to the info bar created a bit of a problem for smaller, mobile screens. In this case I chose to drop the total filament usage data, keeping the total print time, in order to not overly clutter the UI.
Mobile & Desktop Screenshots/Recordings
Default state, show the total for the entire directory:
Selected state, showing the total for only the selected files:
Landscape mobile, dropping the filament usage to keep the UI clean:
Portrait mobile, moving values to be under their label:
Signed-off-by: Titus Stone wastingtape+mainsail@gmail.com