Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Editor): fix editor width when sidebar is hidden #2014

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 15, 2024

Description

This PR fix the width of the editor area, when the filestructur sidebar is closed.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

[optional] Are there any post-deployment tasks we need to perform?

none

Summary by Sourcery

Fix the editor width issue by updating the CSS to handle the presence or absence of the file structure sidebar.

Bug Fixes:

  • Fix the width of the editor area when the file structure sidebar is closed by adjusting the CSS classes.

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 15, 2024
@meteyou
Copy link
Member Author

meteyou commented Sep 15, 2024

@sourcery-ai review

Copy link
Contributor

sourcery-ai bot commented Sep 15, 2024

Reviewer's Guide by Sourcery

This pull request fixes the editor width issue when the file structure sidebar is hidden. The implementation involves updating the CSS classes in the TheEditor.vue component to ensure the editor takes up the full width when the sidebar is closed.

File-Level Changes

Change Details Files
Adjust CSS classes to control editor width based on sidebar visibility
  • Add a new CSS class 'withSidebar' to the codemirror component
  • Update media query to set width:100% when sidebar is hidden
  • Modify existing CSS rule to apply only when 'withSidebar' class is present
src/components/TheEditor.vue

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Sep 15, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meteyou - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/components/TheEditor.vue Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 15, 2024
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 15, 2024
@meteyou
Copy link
Member Author

meteyou commented Sep 15, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meteyou - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@meteyou meteyou merged commit 3b4de5f into mainsail-crew:develop Sep 15, 2024
13 checks passed
@meteyou meteyou deleted the fix/editor-width-sidebar branch September 15, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant