-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating AUTHORS.md from local repo without using GitHub API #33
Comments
There is a trade-off between ease of use and readability. Now the Authors.md has the links to authors: https://github.com/gaocegege/maintainer/blob/master/AUTHORS.md. And maintainer's prior implementation without GitHub support does not have this feature. Yeah I think it should be a opetion. PS: the GitHub API token is not necessary for contributor command. It is needed for changelog command. |
Thanks for your suggestion! |
@gaocegege And why this happens?
|
That's indeed nice! :) Have you also thought about additional GitLab integration, like we do with GitMate? |
Yeah but I have no experience in GitLab. I could have a try :) |
Oh, it seems that we needs token now, my mistake. |
@gaocegege I would like to collaborate a bit in |
Welcome! @userzimmermann 🎉 |
Is this issue abandoned? |
Hey @gaocegege :) You already have the necessary
git
command and regex defined:https://github.com/gaocegege/maintainer/blob/5f09778bcf080f106b77c2f07f6fa3a94bb47688/cmd/contributor.go#L34-L51
But you don't use them. I don't think that many people want to create a GitHub API token just for using maintainer. So this should be optional
The text was updated successfully, but these errors were encountered: