Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating AUTHORS.md from local repo without using GitHub API #33

Open
userzimmermann opened this issue Nov 17, 2017 · 9 comments
Open

Comments

@userzimmermann
Copy link

userzimmermann commented Nov 17, 2017

Hey @gaocegege :) You already have the necessary git command and regex defined:

https://github.com/gaocegege/maintainer/blob/5f09778bcf080f106b77c2f07f6fa3a94bb47688/cmd/contributor.go#L34-L51

But you don't use them. I don't think that many people want to create a GitHub API token just for using maintainer. So this should be optional

@gaocegege
Copy link
Member

There is a trade-off between ease of use and readability.

Now the Authors.md has the links to authors: https://github.com/gaocegege/maintainer/blob/master/AUTHORS.md. And maintainer's prior implementation without GitHub support does not have this feature.

Yeah I think it should be a opetion.

PS: the GitHub API token is not necessary for contributor command. It is needed for changelog command.

@gaocegege
Copy link
Member

Thanks for your suggestion!

@userzimmermann
Copy link
Author

@gaocegege And why this happens?

> maintainer.exe contributor
2017/11/18 05:31:27 There is no config file defined.
2017/11/18 05:31:29 Error when creating AUTHORS.md: GET https://api.github.com/repos/coala/coala/contributors?page=1&per_page=100: 401 Bad credentials []

@userzimmermann
Copy link
Author

@gaocegege

Now the Authors.md has the links to authors

That's indeed nice! :)

Have you also thought about additional GitLab integration, like we do with GitMate?

@gaocegege
Copy link
Member

Yeah but I have no experience in GitLab. I could have a try :)

@gaocegege
Copy link
Member

Oh, it seems that we needs token now, my mistake.

@userzimmermann
Copy link
Author

@gaocegege I would like to collaborate a bit in maintainer, also to get proper coala bears for it... And it's a nice chance to learn some Go dev ;) I will try to make some PRs regarding me ideas... And will create some Google Code-in tasks for those maintainer based bears

@gaocegege
Copy link
Member

Welcome! @userzimmermann

🎉

@baby-gnu
Copy link

Is this issue abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants