False impression on key buffer usage

jmrenouard · jmrenouard · commit b425acd9631a · 2022-03-12T19:14:52.000+01:00
#573 (3)
diff --git a/mysqltuner.pl b/mysqltuner.pl
@@ -3166,12 +3166,13 @@ sub mysql_stats {
     }
     #Cpanel and Skip name resolve
     elsif ( -r "/usr/local/cpanel/cpanel" ){
+        if  ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF') {
+            infoprint "CPanel and Flex system skip-name-resolve should be on";
+        }
         if  ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF') {
             badprint "CPanel and Flex system skip-name-resolve should be on";
             push (@generalrec, "name resolution is enabled due to cPanel doesn't support this disabled.");
             push (@adjvars, "skip-name-resolve=0");
-        else {
-            infoprint "CPanel and Flex system skip-name-resolve should be on";
         }
     }
     elsif ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF' ) {

Original file line number	Diff line number	Diff line change
`@@ -3166,12 +3166,13 @@ sub mysql_stats {`
`3166`	`3166`	`}`
`3167`	`3167`	`#Cpanel and Skip name resolve`
`3168`	`3168`	`elsif ( -r "/usr/local/cpanel/cpanel" ){`
	`3169`	`+ if ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF') {`
	`3170`	`+ infoprint "CPanel and Flex system skip-name-resolve should be on";`
	`3171`	`+ }`
`3169`	`3172`	`if ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF') {`
`3170`	`3173`	`badprint "CPanel and Flex system skip-name-resolve should be on";`
`3171`	`3174`	`push (@generalrec, "name resolution is enabled due to cPanel doesn't support this disabled.");`
`3172`	`3175`	`push (@adjvars, "skip-name-resolve=0");`
`3173`		`- else {`
`3174`		`- infoprint "CPanel and Flex system skip-name-resolve should be on";`
`3175`	`3176`	`}`
`3176`	`3177`	`}`
`3177`	`3178`	`elsif ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF' ) {`