Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capistrano Config: Settings in deploy/$stage.rb should take precedence over deploy.rb #36

Closed
triskweline opened this issue Nov 28, 2017 · 2 comments
Assignees

Comments

@triskweline
Copy link
Member

When the same config setting is defined both in deploy.rb and stage-specific files like deploy/production.rb, the stage-specific setting should take precedence.

Right now it's the other way round due to the implementation of https://github.com/makandra/geordi/blob/master/lib/geordi/capistrano_config.rb .

@codener
Copy link
Member

codener commented Oct 11, 2018

@triskweline is this still an issue? Could you provide additional details?

@triskweline
Copy link
Member Author

Yes, it's still an issue.

In the linked file we use regular expressions to find Capistrano without actually loading the recipe. For this we grep a string of Ruby code (deploy_info) that is concatenated from deploy.rb and deploy/stage.rb (in this order). Since the code then uses the first result from =~, scan, etc. we always get the generic config from deploy.rb rather than the more specific one from deploy/stage.rb.

@codener codener self-assigned this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants