Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geordi work with multiline server declaration #44

Closed
PragTob opened this issue Mar 1, 2018 · 2 comments
Closed

Make geordi work with multiline server declaration #44

PragTob opened this issue Mar 1, 2018 · 2 comments
Assignees

Comments

@PragTob
Copy link

PragTob commented Mar 1, 2018

works:

server "app101-prod.totally-not-makandra.de", user: "deploy_p", roles:   %w[app web db cron], primary: true

breaks:

server "app101-prod.totally-not-makandra.de",
       user:    "deploy_p",
       roles:   %w[app web db],
       primary: true

i.e. geordi shell/console break because @config.user(server) is nil. Like in Util#shell:

      note 'Connecting to ' + server.to_s
      Util.system! 'ssh', "#{ @config.user(server) }@#{ server }", '-t', remote_command

If it's easy to fix (which I hope) I might tackle it myself, for now I'll revert my neatly aligned and 80 char width configuration :)

@triskweline
Copy link
Member

We're currently grepping the deployment config files to avoid booting the bundle and Capistrano into our process.

You might be able to fix this by adding a /m modifier to the regexps in the quoted file, to make . match newlines.

@denzelem
Copy link
Contributor

denzelem commented Nov 5, 2018

Fixed in #51 and included in release 1.10.0.

@denzelem denzelem closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants