Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 1.8.7 #79

Closed
codener opened this issue Feb 12, 2020 · 3 comments
Closed

Drop support for Ruby 1.8.7 #79

codener opened this issue Feb 12, 2020 · 3 comments
Assignees

Comments

@codener
Copy link
Member

codener commented Feb 12, 2020

Since Ruby 1.8 is EOL by far now, let's drop support. In the process, we should simplify the code and remove any 1.8-targeting parts.

@denzelem
Copy link
Contributor

We might need to freeze thor in the gemspec for a last release compatible with Ruby < 2.0.0 before.

Last compatible thor version: 0.20.3 (last release before 1.0.0 where Ruby < 2.0.0 support ist dropped)

Otherwise you will get an error like this:

$ ruby -v
ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux]
$ gem install geordi -v '2.10.1'
ERROR:  Error installing geordi:
	thor requires Ruby version >= 2.0.0.

Workaround:

gem install thor -v '0.20.3'
gem install geordi

@codener
Copy link
Member Author

codener commented Mar 13, 2020

Thanks for pointing this out. The Ruby-2+-Geordi will be released as 3.0.0, so it will be simple to add more 2.x releases at any time.

@denzelem denzelem self-assigned this Apr 8, 2020
@denzelem
Copy link
Contributor

denzelem commented May 4, 2020

@denzelem denzelem closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants