Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeup-floating-label: refresh() method has no effect on select element #85

Open
ianmcburnie opened this issue Aug 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ianmcburnie
Copy link
Member

  1. visit https://makeup.github.io/makeup-js/makeup-floating-label/index.html
  2. Enter values in textboxes and make a selection in select
  3. Click reset button
  4. Click refresh button
  5. Notice select label does not go back to inline position

Looks like floating-label__label--inline is not being applied to the label of the select. Maybe due to this line: https://github.com/makeup/makeup-js/blob/master/packages/makeup-floating-label/src/index.js#L178

@ianmcburnie ianmcburnie added the bug Something isn't working label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant