-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 4 is released now... #664
Comments
Plans are to push the v5.x branch to master, at some point, which will add some features (see #545), fix some bugs, and make Bootbox compatible with both Bootstrap 3 and Bootstrap 4. Waiting on some feedback from @makeusabrew on some of that, as well as figuring out what needs to be done with some of the external dependencies (like NPM, bower, et cetera) to make sure things aren't being broken by the updated repo structure. So, I don't have any hard dates for you. Use the v5.x branch if you really want Bootstrap 4 compatibility, or fork the repo and make the changes noted in #566. |
Subscribed. I am awaiting this now as well. |
tiesont - thanks for the update. #566 is pretty close to what I found too. - the one thing I'm not 100% on is that breakpoints might be different - my understanding is bootstrap 4 -xs designations are now the "default" for example col-xs-12 in bootstrap3 would now be col-12 in bootstrap 4 and so on.. so not sure if the plugin code would need to change to support that? |
@RambosRide The modal markup doesn't include any column markup, so no, that's not relevant or required. I haven't really modified the templates from the current (4.x) version, other than adding a few new templates for new input types (for prompt) and the tweaks needed for the checkbox/radiobutton inputs. I hope to have 5.x released soon. I don't plan on making any more changes, I just need to make sure I have everything in place before doing the switch-over (pulling the v5.x branch into master is just a small part of that). |
Bump - my boss wants me to replace bootbox because its not Bootstrap 4 compatible...any updates on when a version will drop that will? |
The 5x branch is compatible with 3 and 4. I'm not the project owner, so
there's a few things I can't update, or it would be pushed to master
already.
…On Wed, Sep 12, 2018, 10:19 PM RambosRide ***@***.***> wrote:
Bump - my boss wants me to replace bootbox because its not Bootstrap 4
compatible...any updates on when a version will drop that will?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#664 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZpxdbmw98KHnUA-f4aKK8WKTM5BStDks5uacDDgaJpZM4UQaHT>
.
|
Hello, Do you have any idea from when the V5 will be pushed on master ? Thanks |
@yannrobin I can push an update to the master branch, but can't really create releases or update any of the third-party things like npm, so I've been holding off. |
Bootstrap 4 is released now...what are the plans?
The text was updated successfully, but these errors were encountered: