Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to open with proxy or url-handler #143

Closed
lokesh-krishna opened this issue Dec 12, 2020 · 5 comments
Closed

Option to open with proxy or url-handler #143

lokesh-krishna opened this issue Dec 12, 2020 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@lokesh-krishna
Copy link
Contributor

I usually face this problem when I come across HTTP links. I have a HTTP proxy setup but due the nature of HTTP, this is only truly function for minimal, text-focused pages. I would prefer launching my browser, as specified in the [url-handlers] section for links that have content that doesn't fall into this narrow criteria.

I think the best way to handle this, if you're willing to consider it, would be to add new keybinds for "open with proxy" and "open with URL-handler". An example would be if I'm over a HTTP link, I could press Ctrl + P to open it with my proxy and Ctrl + U to open it with my URL handler.

@makew0rld makew0rld added the enhancement New feature or request label Dec 12, 2020
@makew0rld
Copy link
Owner

Thanks for suggesting, this makes sense. I'll add this when I have time, or would accept a PR.

@makew0rld makew0rld added this to the v1.9.0 milestone Dec 24, 2020
@nathandaven
Copy link

just curious, what are you using as your proxy? i'd like to set up an http and a gopher proxy to use amfora with

@makew0rld
Copy link
Owner

@nathandaven You can view some proxies on the wiki: https://github.com/makeworld-the-better-one/amfora/wiki/Proxying#known-proxies

If you come across any others, let me know and I'll add them!

@makew0rld makew0rld modified the milestones: v1.9.0, v1.10.0 May 7, 2021
@makew0rld makew0rld added the documentation Improvements or additions to documentation label Dec 13, 2021
@makew0rld
Copy link
Owner

@lokesh-krishna thinking about this now more that I'm implementing it... isn't just a keybinding for opening with the URL handler needed, Ctrl-U? Because if you want to use the proxy you can just hit Enter, as your proxy setting overrides any URL handlers.

@makew0rld
Copy link
Owner

Ok I added this with just the one keybinding. Let me know if you have any issues @lokesh-krishna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants