Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show indicator of scroll level #89

Closed
Jackymancs4 opened this issue Sep 15, 2020 · 5 comments · Fixed by #107
Closed

Show indicator of scroll level #89

Jackymancs4 opened this issue Sep 15, 2020 · 5 comments · Fixed by #107
Labels
enhancement New feature or request question Further information is requested upstream The issue is with a library.
Milestone

Comments

@Jackymancs4
Copy link

Hello @makeworld-the-better-one

I found myself reading a very long gemini post recently (for reference: gemini://l-3.space/split-keys.gmi ) and it came up in my mind that it would be nice to now how long until I reach the end.

As a possible idea, splitting the bottom status bar in two, where on the left there is the bar as there is now, and aligned on the right there is somenthing like number_bottom_line:number_of_lines_in_document or some form of percentage.

Ideally some form of scroll bar (vertical) or reading progress bar (horizontal).

@makew0rld makew0rld added enhancement New feature or request question Further information is requested upstream The issue is with a library. labels Sep 15, 2020
@makew0rld
Copy link
Owner

This is a good idea, thanks. The underlying TUI library Amfora uses, cview supports scrollbars for some things, but not just text views, like pages are. I've opened up issue 34 to see if that could be supported.

Having some stats in the bottom right is a good solution, I like it a lot, for all kinds of things potentially (meta string, for example). Unfortunately, the current object for the bottom bar is an InputField, which will make adding arbitrary right-aligned text not straight-forward. Definitely possible though, so I will look into it at some point.

@makew0rld
Copy link
Owner

This is a good idea, thanks. The underlying TUI library Amfora uses, cview supports scrollbars for some things, but not just text views, like pages are. I've opened up issue 34 to see if that could be supported.

Issue 34 has been closed, scrollbars for text views are now supported in cview commit 441992fd.

I plan on updating the cview dependency to support to this feature, and adding a new config option to turn it on and off. I'm thinking of leaving it on by default, but open to hearing opinions on that.

@bouncepaw
Copy link
Contributor

I like vim's approach to this. It shows Top on top of document, Bot on bottom and percentage in other cases. It's quite handy and intuitive (if you rename Bot to Btm or 100%).

@makew0rld makew0rld mentioned this issue Nov 5, 2020
29 tasks
@makew0rld
Copy link
Owner

makew0rld commented Nov 5, 2020

scrollbars for text views are now supported in cview

I plan on updating the cview dependency to support to this feature, and adding a new config option to turn it on and off.

This will be added in #107.

@makew0rld makew0rld added this to the v1.7.0 milestone Nov 5, 2020
@makew0rld makew0rld modified the milestones: v1.7.0, v1.8.0 Dec 9, 2020
@makew0rld
Copy link
Owner

@Jackymancs4 You mentioned an approach using line numbers originally, and @bouncepaw you mentioned percentages. While the scroll bar method mentioned above is still planned, I will also be adding support for these other methods as part of an info bar. See #142 and feel free to comment there.

cc @pixdrift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested upstream The issue is with a library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants