Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaiji replacement is not working on non-japanese systems #12

Open
scrpr opened this issue Dec 3, 2023 · 0 comments · May be fixed by #13
Open

Gaiji replacement is not working on non-japanese systems #12

scrpr opened this issue Dec 3, 2023 · 0 comments · May be fixed by #13

Comments

@scrpr
Copy link

scrpr commented Dec 3, 2023

Caption.all will assume all characters to be shift-jis encoded, causing this functionality practiaclly broken.
One solution comes from (NMM-HD)[https://www.nmm-hd.org/newbbs/viewtopic.php?f=16&t=720&p=6874] and it works perfectly on other codepages.
@scrpr scrpr changed the title Ganki replacement is not working on non-japanese systems Ganji replacement is not working on non-japanese systems Dec 3, 2023
@scrpr scrpr linked a pull request Dec 3, 2023 that will close this issue
Open
@scrpr scrpr changed the title Ganji replacement is not working on non-japanese systems Gaiji replacement is not working on non-japanese systems Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix gaiji replacement not working on non-japanese systems scrpr/Caption2Ass_PCR
1 participant
@scrpr