Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollViewEventsHandler is not public and can't be accessed to listen scroll events #26

Closed
CureleaAndrei opened this issue Jun 11, 2019 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CureleaAndrei
Copy link

CureleaAndrei commented Jun 11, 2019

Hi, I am trying to set scrollview delegates on a FlowCollectionDirector, folowing the readme. I can get only to the scrollEvents property but when i try to acces any of it's delegates i get an error like this : 'didScroll' is inaccessible due to 'internal' protection level.

I think the problem is that for ScrollViewEventsHandler properties there is no public access modifier and the default is internal. If this is the desired behavior, can you please explain how can we set those delegates?

Ty for this great library! It's really helpfull

@bunnyhero
Copy link
Contributor

I'm having this issue too. IMHO the members of ScrollViewEventsHandler should be public, otherwise I don't see any reason for them to exist. This is a real blocker for me right now :(

@bunnyhero
Copy link
Contributor

I see this has been fixed on the develop branch: ee4ffff

Is there any way I can help the CocoaPod get updated with this fix? Thanks :)

@CureleaAndrei
Copy link
Author

Hi, any news on this ? It is merged?

@malcommac
Copy link
Owner

I’ll be back from holidays next week and I’ll look at this ASAP. Thanks for the patience

@CureleaAndrei
Copy link
Author

No problem. Have a nice Holiday 😄.

@malcommac malcommac added this to the 1.1.0 milestone Sep 15, 2019
@malcommac malcommac added the bug Something isn't working label Sep 15, 2019
@malcommac malcommac self-assigned this Sep 15, 2019
@malcommac malcommac changed the title can't set any scroll delegate ScrollViewEventsHandler is not public and can't be accessed to listen scroll events Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants