Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Julia API for NewPassManager createFunctionToLoopPassAdaptor #421

Open
wsmoses opened this issue Jun 15, 2024 · 1 comment
Open

Comments

@wsmoses
Copy link
Contributor

wsmoses commented Jun 15, 2024

It makes use of a loop pass like JuliaLICMPass more difficult

@maleadt
Copy link
Owner

maleadt commented Jun 17, 2024

Is this so long that it needs an additional helper?

@dispose ctx=Context() pb=NewPMPassBuilder() begin
    add!(pb, NewPMFunctionPassManager()) do fpm
        add!(fpm, NewPMLoopPassManager()) do lpm
            add!(lpm, JuliaLICMPass())
            ...

vs. the hypothetical:

@dispose ctx=Context() pb=NewPMPassBuilder() begin
    add!(pb, NewPMFunctionPassManager()) do fpm
        add!(fpm, createFunctionToLoopPassAdaptor(JuliaLICMPass()))
        ...

For saving a single LOC that doesn't seem worth the additional API entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants