-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe pythonic access to newly created agents #468
Comments
Error Handling Prefer not to have asserts in an underlying library. It takes away choice from the user of the library. Exceptions or return codes - I'm fine either way. Maybe a group question on slack to canvas opinions on how we'd generally like to do error handling in the backend? |
Some python questions here - how it is handling unique pointers and exceptions? |
I talked to @basicNew and @hidmic about this for a bit today. Here's a quick summary of our discussion:
@stonier Does that sound like a reasonable plan to you? |
After further discussion, we are going to go the drake route of using throw, but not catch. This essentially gives us more fancy asserts, with the possibility of handling them later. PR upcoming. |
This is done as of #502, so closing for now. |
AddAgent
should be a bit better at error handling - right now we have c++ coverage! assert, exceptions and return codes.The text was updated successfully, but these errors were encountered: