-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dual_opposing_dedicated_right_turn_lanes map #36
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Thanks for creating this! I'll test it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments to go!
One extra comment, you can add the generation of this map to the tool script: https://github.com/maliput/maliput_xodr/blob/main/tools/update_resources.sh |
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@liangfok , I pushed some fixes mainly related to the traffic direction rules. For testing use the latest files that I now pushed. |
Got it. I just grabbed the latest revision. Thanks for the note. |
Gently ping to check if this PR is mergeable as it is. @liangfok |
This is still undergoing the initial review, but based on work in #37, I will likely have to re-generate the map using our downstreawm tooling once our downstream tooling supports stop lines with and without stop signs. I'm going to wait for #37 to pass initial testing before refocusing on this map. |
Friendly ping @liangfok . Based on this result, is it necessary to update something here? |
I continue to wait for our downstream users to evaluate this map. This particular map is a lower priority for them, so it might be a while before they have the cycles to evaluate it. They are just starting to use the map in 54a70d4. |
Great! Thanks for the update! Let's wait for the feedback then. |
I need to fix minor conflicts due to the last PRs that got merged. However, let me know if this PR is mergeable @liangfok |
Will do. Currently our downstream users are focused on other maps, but will definitely return to this one in the future. |
Let's rename this map "dual_opposing_dedicated_right_turn_lanes." This is to highlight the fact that the dedicated turn lanes are right turn lanes rather than left turn lanes, which is more important than the fact that they are oriented North/South. |
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Done. |
Ready to review @liangfok |
Just a quick note that @max-shaan is helping out with the downstream usage of this map. |
I noticed that the south-bound dedicated right turn lane is not modeled, which makes sense given the graphic above. I'm asking our downstream users whether this is expected since it is odd for there to be a south-bound middle lane in the north segment without it being a dedicated right-turn lane. |
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
79a741a
to
5982e29
Compare
🎉 New feature
Closes #29
Summary
Solves the following map:
Test it
Following the instructions in the readme, you can reproduce the map.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.