Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a precision for the float numbers in the geojson file #56

Open
francocipollone opened this issue Nov 7, 2023 · 1 comment
Open

Comments

@francocipollone
Copy link
Contributor

Summary

Fix a precision number for the creation lat-lon coordinates that are dumped into the geojson file.
This will avoid different values when running in different machines. In particular it will unblock #55

Proposal

Using 7 decimals we are targeting a precision of 0.0001 m (111.139 * 1e-7 =~0.0001 )

Originally posted by @francocipollone in #55 (comment)

@liangfok
Copy link
Contributor

liangfok commented Nov 7, 2023

I'm totally fine with the proposal since it's the simplest fix. Below are some random thoughts.

  1. Auto-select the number of decimal places based on Maliput's inertial position tolerance. Choose the smallest number of decimal places to achieve a precision smaller than this tolerance.
  2. Make the number of decimal places user-specifiable, with 7 decimal places as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants