New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme instructions are wrong - hash doesn't exist #26

Open

berney opened this issue May 11, 2022 · 0 comments

berney commented May 11, 2022

The readme includes instructions:

repos:
- repo: https://github.com/maltzj/google-style-precommit-hook
  sha: b7e9e7fcba4a5aea463e72fe9964c14877bd8130
    hooks:
      - id: google-style-java

There is no hash b7e9e7fcba4a5aea463e72fe9964c14877bd8130 in this projects git history.

git fetch --all
git log --all | grep -i b7e9e7fcba4a5aea463e72fe9964c14877bd8130 --count
0

Also since pre-commit 1.7.0, it should be rev not sha.

It would be convenient to use tags for releases IMO, but SHAs have the benefit of being immutable. If they were correct.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment