Upload with --force doesn't regenerate repodata.json

[wolfv]

When uploading the same package version again (using --force) the repodata is not generated, which can lead to SHA256 and file size mismatches.

We should properly store the new checksum & file size and regenerate the repodata.json.

[brichet]

@wolfv I can't reproduce it.
Using the quetz-client command line the repodata.json file is modified, including SHA256 and MD5 values.
Can you give some more context to reproduce it ?

[wolfv]

Did you upload two different files with the exact same name?

[brichet]

Yes, the exact same name, returning an error without the --force flag.
I tested with the xtensor package, by adding a file in the package archive to change the resulting hash.

[brichet]

There are 2 different API requests that can upload a package :

quetz/quetz/main.py

Lines 1284 to 1288 in d272e61

	@api_router.post(
	"/channels/{channel_name}/packages/{package_name}/files/",
	status_code=201,
	tags=["files"],
	)

and

quetz/quetz/main.py

Line 1375 in d272e61

@api_router.post("/channels/{channel_name}/files/", status_code=201, tags=["files"])

The first one doesn't build the repodata.json file at all.

This may be the error you have encountered.

[wolfv]

we could check which one is used by the quetz-cli that uploads packages.

[brichet]

The quetz-client use by default the one which build the repodata, if only a channel name is provided.
But the full URL to the API can be provided, like the example in the README :

quetz/README.md

Line 80 in d272e61

quetz-client http://localhost:8000/api/channels/channel0 xtensor/linux-64/xtensor-0.16.1-0.tar.bz2 xtensor/osx-64/xtensor-0.16.1-0.tar.bz2

We should fix the first API function anyway.

[wolfv]

For sure! Thanks for working on this!

[brichet]

Should be fixed in #555
@wolfv do you still have the error ?