Allow setting timestamp when writing archives #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Apr 17, 2023
| @@ -120,6 +120,7 @@ pub fn write_tar_bz2_package<W: Write>( | |||
| base_path: &Path, | |||
| paths: &[PathBuf], | |||
| compression_level: CompressionLevel, | |||
| timestamp: &Option<chrono::DateTime<chrono::Utc>>, | |||
There was a problem hiding this comment.
Please use Option<&T> instead of &Option<T>.
|
thx for the suggestion, done that. I was considering to add a "options" struct, but not convinced it's needed just yet. |
|
Yeah if we add more we should do that. But lets merge as is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cobbled something together to help build "reproducible" archives.
This deterministically sets the timestamp of all files in an archive. That worked for a quick test of building a reproducible package :)
However, we could come up with more interesting schemes of modifying the timestamps (e.g. only forcing the timestamp on files that have been written in the past 24 hours or so, and leave those files that were just copied from the source archive as they are).
Some references: https://reproducible-builds.org/docs/timestamps/