feat: compute hashes while extracting #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
feat/compute_hashes_while_extracting
branch
2 times, most recently
from
41951ca to
2d5d7e5
Compare
baszalmstra
force-pushed
the
feat/compute_hashes_while_extracting
branch
from
2d5d7e5 to
e16af90
Compare
|
just to be sure – this computes the hash of the outer archive on the fly, correct? E.g. the hash of the I think that's great :) Do we take any actions when the hash doesn't match? E.g. removing the archive & extracted contents? |
Yes, that's exactly what it does!
No not yet, that's what the package cache should do. The extraction process itself is unaware of the expected hash. |
wolfv
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This computes the hashes of extracted archives on the fly. I think this is really fast and shouldn't add much overhead (compared to disk and network access) but we can also put it behind flags that we pass in. Or we can separate this concern into different functions. However, I also think its good practice to check the hash of the downloaded file to ensure consistency so 🤷
Let me know what you think!
Fixes: #41