Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tls features to rattler dependencies as well #181

Merged
merged 8 commits into from
Apr 29, 2023
Merged

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Apr 26, 2023

I think this is needed.

@baszalmstra
Copy link
Collaborator

Ah yes! I also think you need to disable default features of rattler_package_streaming in the rattler crate.

@wolfv
Copy link
Contributor Author

wolfv commented Apr 26, 2023

I now have to add it to every crate that depends on rattler_conda_types because that has a dev-dependency on package_streaming. So I have to add the feature to every crate more or less.

Or am I missing something?

@baszalmstra
Copy link
Collaborator

I dont think you need to add the feature to the dev dependencies! The tests can just run with nativetls.

@wolfv
Copy link
Contributor Author

wolfv commented Apr 26, 2023

It doesn't compile though. But actually I could force the tests to use rustls-ROS

@wolfv
Copy link
Contributor Author

wolfv commented Apr 26, 2023

Hmm, I still see some native-tls dependency coming from tokio-native-tls ... maybe we can fix this together on friday :)

@wolfv wolfv merged commit e1e0168 into conda:main Apr 29, 2023
@wolfv wolfv deleted the tls branch April 29, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants